Update to use cmake presets #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README. Update vcpkg commit hash for dependencies. Fix bugs.
|
@elantzb I cannot mark you as a reviewer, but tagging you here |
elantzb
reviewed
Jul 11, 2022
|
Update this to use latest c++ language standard. |
|
I recommend updating the description on the PR/commit to be more verbose. For the sake of a paper trail if needed in the future. |
|
This will require protocolbuffers/protobuf#10232 to be merged into a new version and the the version needs to be put on VCPKG and the baseline commit hash needs to be updated. |
Fix include in pxiel-buffer.cpp being nested under tec namespace. The compiler was errantly looking for tec::std::man because of this. Add launch confing for vscode. Properly set c++17 via target_compile_features interface to propagate
Change build images
Add visual studio launch.vs.json. Fix tests not being found and properly link gtest libs.
Update build preset descriptions to be a bit less pedantic.
elantzb
reviewed
Jul 22, 2022
elantzb
reviewed
Jul 22, 2022
Remove no longer relevant selene include from CMakeLists. Add VS_DEBUGGER_WORKING_DIRECTORY to client and server CMakeLists to define the desired working directory.
|
Visual studio 2017 is not supported any longer it appears due to sol2 ThePhD/sol2#1362 |
elantzb
reviewed
Jul 23, 2022
elantzb
reviewed
Jul 23, 2022
elantzb
reviewed
Jul 23, 2022
Fix documentation warnings.
|
Prior run was successful and the final commit should have skipped run as it was a typo fix to the README. I am going to merge this via admin powers instead of waiting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to use CMake presets and update documentation generation, and the README, along side various bug fixes.
Description
Update README and added docs generation targets.
Fix readthedoc setup by including python requirements.
Update vcpkg commit hash for dependencies.
Change to use CMake presets with ninja multi config.
Fix asset failing to load missing null pointer check for animation.cpp.
Some adjustments to fmt.
Fix Dead ImGUI root window id being empty.
Add EOL find utility for md5anim and obj parsing. This should be replaced by a better check @elantzb .
Add better validation to md5anim parsing.
Remove explicit default constructor for Mesh.hpp Vertex
Update CMake min version to 19.
Fix include in pxiel-buffer.cpp being nested under tec namespace.
The compiler was errantly looking for tec::std::man because of this.
Add launch config for vscode.
Properly set c++17 via target_compile_features interface to propagate
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: